Conversation
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
casaroli
reviewed
Nov 19, 2025
| // Shared heap for memory-mapped access | ||
| wasm_shared_heap_t _shared_heap = NULL; | ||
| #ifdef CONFIG_OCRE_SHARED_HEAP_BUF_VIRTUAL | ||
| uint8 preallocated_buf[CONFIG_OCRE_SHARED_HEAP_BUF_SIZE]; |
Contributor
There was a problem hiding this comment.
Should we allocate and put this in the external ram (storage_malloc) or (user_malloc) instead of making it global/static?
Collaborator
Author
There was a problem hiding this comment.
I am fine with either - but with current solution we would still use system memory (just allocated dynamically) on systems with no PSRAM, will need to cut a bit WAMR's linear memory and allocate/deallocate memory during the runtime init.
I propose the following: we keep it this way as initial commit for this features, and once the shared_memory is available and non-kernel stuff are using the same pull, we will move everything (inc. this) to use that.
|
|
||
| #ifdef CONFIG_OCRE_SHARED_HEAP_BUF_PHYSICAL | ||
| // Physical mode - map hardware register address | ||
| heap_init_args.pre_allocated_addr = (void *)CONFIG_OCRE_SHARED_HEAP_BUF_ADDRESS; |
Contributor
There was a problem hiding this comment.
This looks like something very dangerous to do as this memory is potentially used by the OS.
Collaborator
Author
There was a problem hiding this comment.
This is to give the user the possibility to manipulate hardware (like GPIOs) from the container - it can be enabled or disabled from the config. But yes, user shall take care and understand, that if they use it it's dangerous.
casaroli
approved these changes
Nov 19, 2025
PatrickRobbIOL
pushed a commit
to mgeeIOL/ocre-runtime
that referenced
this pull request
Dec 1, 2025
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
casaroli
pushed a commit
that referenced
this pull request
Dec 7, 2025
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
casaroli
added a commit
that referenced
this pull request
Jan 7, 2026
This reverts commit f555f1b. This commit is kept in the legacy branch.
casaroli
pushed a commit
that referenced
this pull request
Jan 7, 2026
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
casaroli
added a commit
that referenced
this pull request
Jan 7, 2026
This reverts commit f555f1b. This commit is kept in the legacy branch. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
pushed a commit
that referenced
this pull request
Jan 7, 2026
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com> Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
pushed a commit
that referenced
this pull request
Jan 7, 2026
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com> Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
added a commit
that referenced
this pull request
Jan 7, 2026
This reverts commit f555f1b. This commit is kept in the legacy branch. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
pushed a commit
that referenced
this pull request
Jan 7, 2026
Update wamr's hash to support networking DNS changes. --------- Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com> Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement of wasm stack - additional networking and shared memory support
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests on Linux, Zephyr and CI
Checklist: